Skip to content

Commit

Permalink
remove xfail
Browse files Browse the repository at this point in the history
  • Loading branch information
isabelizimm committed Oct 13, 2022
1 parent f8f8632 commit 9b88845
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install -e .[dev,torch]
python -m pip install -e .[dev]
- name: run RStudio Connect
run: |
docker-compose up --build -d
Expand Down
21 changes: 15 additions & 6 deletions vetiver/tests/test_rsconnect.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import pytest
import json
import sklearn
import pins
from pins.boards import BoardRsConnect
from pins.rsconnect.api import RsConnectApi
from pins.rsconnect.fs import RsConnectFs
Expand All @@ -24,6 +25,12 @@ def server_from_key(name):
return RSConnectServer(RSC_SERVER_URL, api_key)


def get_key(name):
with open(RSC_KEYS_FNAME) as f:
api_key = json.load(f)[name]
return api_key


def rsc_from_key(name):
with open(RSC_KEYS_FNAME) as f:
api_key = json.load(f)[name]
Expand Down Expand Up @@ -67,18 +74,20 @@ def test_board_pin_write(rsc_short):
assert isinstance(rsc_short.pin_read("susan/model"), sklearn.dummy.DummyRegressor)


@pytest.mark.xfail
def test_deploy(rsc_short):
v = vetiver.VetiverModel(
model=model, ptype_data=X_df, model_name="susan/model", versioned=None
)

vetiver.vetiver_pin_write(board=rsc_short, model=v)
connect_server = RSConnectServer(
url=RSC_SERVER_URL, api_key=server_from_key("susan")
board = pins.board_rsconnect(
server_url=RSC_SERVER_URL, api_key=get_key("susan"), allow_pickle_read=True
)

vetiver.vetiver_pin_write(board=board, model=v)
connect_server = RSConnectServer(url=RSC_SERVER_URL, api_key=get_key("susan"))
assert isinstance(board.pin_read("susan/model"), sklearn.dummy.DummyRegressor)

vetiver.deploy_rsconnect(
connect_server=connect_server, board=rsc_short, pin_name="susan/model"
connect_server=connect_server, board=board, pin_name="susan/model"
)
response = vetiver.predict(RSC_SERVER_URL + "/predict", json=X_df)
assert response.status_code == 200, response.text
Expand Down

0 comments on commit 9b88845

Please sign in to comment.