Add tests for ebut-link-directly and gbut-link-directly #410
Conversation
| (with-simulated-input "button RET" | ||
| (hui:ebut-link-directly (get-buffer-window) (get-buffer-window dir-buf)) | ||
| ;; Implicit link should be the `dir' dired directory, | ||
| ;; possibly minus the final directory '/'. |
There was a problem hiding this comment.
This is copied from the ibut test case. @rswgnu Why the possibly? Apparently a directory can be without a trailing slash in the ebut args, but why?
I transformed it in this test case to a file name so the test will pass but that feels a bit hacky. Should we not make sure all link-to-directory ebuts have a trailing slash?
Can this be related to that environment variables can be inserted in the ebut args and that it could make it hard to be consistent? Do we need to relax the requirement for a trailing slash here so that the helper function, hy-test-helpers-verify-hattr-at-p, should ignore the trailing slash difference?
There was a problem hiding this comment.
I think so. There are too many code paths where a dir without a final slash could come in.
There was a problem hiding this comment.
OK. Will update the general helper check so that when verifying a link-to-directory both versions, with and without slash i checked.
matsl
changed the title
What
Add tests for ebut-link-directly and gbut-link-directly.
Note
Copied from similar ibut test cases.