Matsl rsw strange auto mode alist org issue #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are failing; Mats, see if you can fix them.
Make hyrolo cache variables buffer-local to allow multiple commands
to have their own hyrolo display buffers.
Fix hyrolo-logic.el to handle multiple file formats (not yet tested).
test/hyrolo-tests.el (hyrolo-demo-move-to-beginning-and-end-of-file):
Move to {,} and {.} tests to sep test.
kotl-mode - Fix check of 'kotl-previous-mode' to not set local vars if prior mode was the same, i.e. kotl-mode.
Fix HyRolo file wildcard handling in hpath:expand-list.
(hyrolo-to-entry-end): Remove unused arg '_curr-entry-level-len'. (hyrolo-grep-file): Remove unneeded passing of 'curr-entry-level-len' arg to (hyrolo-outline-previous-visible-heading, hyrolo-next-visible-heading): Fix doc strings to mention stops at match buffer headers.
hibtypes.el (Info-node): Tighten match to limit valid chars after closing paren.
(hyrolo-stuck-msg): Add to jump to the position where a HyRolo match
became stuck, if ever happens, when point is on the error.
hyrolo.el (hyrolo-grep-file): Update 'Stuck looping in buffer' msg so can be
used in new 'hyrolo-stuck-msg' ibtype.
man/hyperbole.texi (Implicit Button Types): Add doc for 'hib-python-traceback'
and 'hyrolo-stuck-msg'.
hyperbole.el: The 'describe-package' function fails under Emacs 28 when multiple
maintainers are listed under the 'Maintainer' header but later Emacs versions
support a 'Maintainers' header, so include both. Change to using 'Authors'
Will also install the markdown-mode package as necessary when a Markdown file is specified in 'hyrolo-file-list'. This fixes failures with Markdown files improperly put into fundamental-mode which means their headings are not recognized properly. hload-path.el (auto-mode-alist): Setup to invoke 'outline-mode' on ".otl" suffixed files. man/hyperbole.texi (HyRolo Concepts): hyrolo.el (hyrolo-file-list): Update doc to specify allowable file suffixes and types.
Fix 'hpath--expand-auto-variable-alist' and 'hpath--resolve-auto-variable-alist' tests.
In same keymap, fix , and . movement keys. For all supported HyRolo major modes, include file headers in both hyrolo-hdr-regexp and outline-regexp.
Disable reveal-mode until can get it to work properly with outline-minor-mode. Fix hyrolo-tests.el tests that prompt to re-read-in files.
Note discrepancies from expected behavior are added as comments.
Matsl rsw hui link possible types
This avoids the query for the local vars when the tests are run interactively.
Set enable-local-variables to nil for tests with DEMO and FAST-DEMO
hmouse-alist-add-window-handlers - Default to implicit button creation; create explicit button with C-u prefix.
Add example of ERT test action buttons to DEMO, FAST-DEMO and the manual. Add ERT test action button support for ert-deftext-async definitions from the "ert-async.el" package. Fix smart-lisp tag finding to exclude outside <> chars when are part of action buttons. Fix text-toc actype to only match to given text at the start of a heading.
Matsl rsw add hyrolo tests
*HyRolo* buffer {n} and {p} improvements across file headers but
not fully finished.
Add backtrace to `hyrolo-file-list' error buffer when within a 'let'.
This puts backtraces for test failures into the *Messages* buffer for quick issue resolution.
Previously, had to have loaded the test def from a file; now can use TAGS files to find its location. Use this incantation to set this up. (setq find-function-regexp-alist (assq-delete-all 'ert--test find-function-regexp-alist)) ;; Could also set this to `smart-lisp-find-tag' instead of `xref-find-definitions'. (add-to-list 'find-function-regexp-alist '(ert--test . xref-find-definitions))
Revert batch ert change since interactive works better and updates we have made to ert support in "hypb-ert.el". Fix ert edebug test.
Skip org-fold-region dependent test when org-version is 9.6 and above due to incompatibility with org version 9.6 to be fixed separately.
Run all hyrolo tests make test SELECTOR=hyrolo Bonus. Control size of backtraces so that we get more info on errors. For full backtrace add command line argument FULL_BT= make test SELECTOR=hyrolo FULL_BT=
…selector Run tests in batch mode specified by selector
Add ibut:is-type-p and change 'ibut:at-type-p'. Add 'hbut:actype' and 'ibut:type'.
Change call from 'make-symbol' to 'intern' for efficiency.
Tests depending on fold behavior in org mode have been skipped for org mode later or equal to 9.6. This is so that all Emacs versions will pass the CI/CD build. When this BUG is fixed in hyrolo these guards can be removed.
hypb:display-file-with-logo now auto sets and uses Org mode and allows
global headline cycling via {TAB} when at blank line at the beginning
of the buffer. This eliminates the need for local variables which have
been removed from the doc files. Also expands any folded headings in
the file. Improve use in tests by doing the following when in batch mode,
i.el noninteractive execution: Kill off any non-modified buffer showing
the file to display before freshly reading it.
New variable `hsys-org-cycle-bob-file-list' specifies the list of files
that get automatic beginning of buffer heading exposure cycling from
a call to `hypb:display-file-with-logo'.
hyrolo.el (hyrolo-org-mode): Add newer Org 9.7-pre hide/show support.
hyrolo-tests.el (hyrolo-tests--outline-hide-show-heading,
hyrolo-tests--outline-show-when-moving-out-of-hidden-line):
The above change fixes these tests, so they have been re-enabled.
hmouse-tag.el (smart-lisp-identifier-chars): Add @ char as advised functions
use the orig-function@advice-wrapper-name to refer to the advice.
hpath.el (hpath:variables): Move 'load-path' and 'exec-path' before
'Info-directory-list' as they should be higher priority matches.
Remove old 'Info-directory'.
|
Closing this. It is no longer needed as this has been fixed in the 'rsw' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Demoing the strange auto mode alist org issue.
Why
Seems we have a regression whith org mode being removed from the auto-mode-alist. There are also other org related errors, like missing variable.
See commit for the actual change: f0837c2