Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified GnuTLS priority according to standard crypto-policy guideline #171

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

jvymazal
Copy link
Contributor

Edited TLS priority string default to conform to system-wide default
and align librelp behavior with other crypto-utilizing packages

@jvymazal
Copy link
Contributor Author

second attempt to solve #57

@jvymazal
Copy link
Contributor Author

@rgerhards, as the code has been massively rewritten I canceled the original PR altogether and created this one instead where I re-implemented required changes onto the new code.

Edited TLS priority string default to conform to system-wide default
and align librelp behavior with other crypto-utilizing packages
@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

Merging #171 into master will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage    74.6%   74.54%   -0.07%     
==========================================
  Files          21       21              
  Lines        3950     3956       +6     
==========================================
+ Hits         2947     2949       +2     
- Misses       1003     1007       +4
Impacted Files Coverage Δ
src/tcp.c 71.67% <83.33%> (-0.09%) ⬇️
src/sendbuf.c 66.66% <0%> (-7.58%) ⬇️
tests/send.c 78.96% <0%> (-1.72%) ⬇️
src/relp.c 77.65% <0%> (+0.54%) ⬆️
src/cserverclose.c 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e540249...01bbdc9. Read the comment docs.

@rgerhards rgerhards added this to the 1.6.0 milestone Apr 17, 2020
@rgerhards
Copy link
Member

@jvymazal sorry for the veeeeery laaaaate reply - looks like I forgot to assign a milestone. But now it is finally part of the upcoming release :-)

@rgerhards rgerhards self-assigned this Apr 17, 2020
@rgerhards rgerhards merged commit 3fd45be into rsyslog:master Apr 17, 2020
@rgerhards
Copy link
Member

@jvymazal not sure, but I guess the openssl driver may now work slightly different. Maybe you want to have a look to align that as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants