Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock components対応 #86

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Mock components対応 #86

merged 4 commits into from
Jan 28, 2025

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Jan 17, 2025

What does this implement/fix?

Mock componentsに対応し、実機不要で動作確認ができるようになります。

Does this close any currently open issues?

しません

How has this been tested?

READMEに記載の手順で起動し、joint_values、gripper_control等のサンプルや、RVizを用いてアームやグリッパが動くことを確認しました。
https://github.com/rt-net/crane_plus/tree/feature/add_mock_components/crane_plus_examples#準備mock-componentsを使う場合

Any other comments?

ないです

Checklists

@Kuwamai Kuwamai added the Type: Feature New Feature label Jan 17, 2025
@Kuwamai Kuwamai requested a review from YusukeKato January 17, 2025 10:34
@Kuwamai Kuwamai self-assigned this Jan 17, 2025
@Kuwamai
Copy link
Contributor Author

Kuwamai commented Jan 17, 2025

Rolling用のCIでgz-ros2-controlのインストールに失敗しますが、これは一時的な不具合のようです。

@YusukeKato
Copy link
Collaborator

実機とシミュレータ環境なしで各サンプルが動作することを確認しました。
RVizからMoveItでアームとグリッパが動くことを確認しました。

Copy link
Collaborator

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@Kuwamai
Copy link
Contributor Author

Kuwamai commented Jan 27, 2025

@YusukeKato
gz-ros2-controlのリリースはまだ先になりそうなのでUPSTREAM_WORKSPACEに追加しました。
ご確認お願いします。

@YusukeKato
Copy link
Collaborator

確認しました!
LGTMです。

@YusukeKato YusukeKato merged commit 0e80b11 into master Jan 28, 2025
4 checks passed
@YusukeKato YusukeKato deleted the feature/add_mock_components branch January 28, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants