sciurus17、sciurus17_toolsのROS 2対応 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShotaAk
suggested changes
Nov 9, 2023
sciurus17/package.xml
Outdated
|
|
||
| <license>Apache License 2.0</license> | ||
|
|
||
| <author email="[email protected]">Hiroyuki Nomura</author> | ||
| <author email="[email protected]">Shota Hirama</author> | ||
| <author email="[email protected]">Atsushi Kuwagata</author> |
sciurus17_tools/package.xml
Outdated
| <author email="[email protected]">Hiroyuki Nomura</author> | ||
| <author email="[email protected]">Shota Hirama</author> | ||
| <license>Apache License 2.0</license> | ||
| <author email="[email protected]">Atsushi Kuwagata</author> |
sciurus17_tools/package.xml
Outdated
Comment on lines
15
to
17
| <url type="website">http://wiki.ros.org/sciurus17_ros</url> | ||
| <url type="bugtracker">https://github.com/rt-net/sciurus17_ros/issues</url> | ||
| <url type="repository">https://github.com/rt-net/sciurus17_ros</url> |
There was a problem hiding this comment.
sciurus17パッケージに記載しているので不要です
Suggested change
| <url type="website">http://wiki.ros.org/sciurus17_ros</url> | |
| <url type="bugtracker">https://github.com/rt-net/sciurus17_ros/issues</url> | |
| <url type="repository">https://github.com/rt-net/sciurus17_ros</url> | |
| <url type="website">http://wiki.ros.org/sciurus17_ros</url> | |
| <url type="bugtracker">https://github.com/rt-net/sciurus17_ros/issues</url> | |
| <url type="repository">https://github.com/rt-net/sciurus17_ros</url> |
sciurus17_tools/package.xml
Outdated
| <name>sciurus17_tools</name> | ||
| <version>2.0.0</version> | ||
| <description>The sciurus17_tools package</description> | ||
|
|
||
| <description>ROS 2 package suite of Sciurus17</description> |
| RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION} | ||
| ) | ||
|
|
||
| install(DIRECTORY scripts rules DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}) |
There was a problem hiding this comment.
lib以下にインストールすると、ros2 run sciurus17_tools create_udev_rulesでコマンド実行できます。
変更お願いします。
install(DIRECTORY
scripts
rules
DESTINATION lib/${PROJECT_NAME}/
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
不要なファイルの削除とsciurus17、sciurus17_toolsのROS 2対応を行いました。
Does this close any currently open issues?
しません
How has this been tested?
パッケージがビルドできることを確認しました。
Any other comments?
なし
Checklists