fix: use SITE_URL for GraphQL endpoint instead of HOME_URL
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2a2a63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 14394092408Details
💛 - Coveralls |
justlevine
reviewed
Apr 11, 2025
| @@ -374,7 +374,8 @@ class SnapWPConfigManager { | |||
| */ | |||
| static getGraphqlUrl(): string { | |||
| return generateGraphqlUrl( | |||
| SnapWPConfigManager.getConfig().wpHomeUrl, | |||
| SnapWPConfigManager.getConfig().wpSiteUrl || | |||
| SnapWPConfigManager.getConfig().wpHomeUrl, | |||
There was a problem hiding this comment.
wpSiteUrl already falls back to wpHomeUrl.
Suggested change
| SnapWPConfigManager.getConfig().wpHomeUrl, | |
| SnapWPConfigManager.getConfig().wpSiteUrl, |
justlevine
reviewed
Apr 11, 2025
packages/query/codegen.ts
Outdated
| @@ -13,7 +13,8 @@ const config: CodegenConfig = { | |||
| schema: process.env.GRAPHQL_SCHEMA_FILE ?? [ | |||
| { | |||
| [ generateGraphqlUrl( | |||
| process.env.NEXT_PUBLIC_WP_HOME_URL, | |||
| process.env.NEXT_PUBLIC_WP_SITE_URL || | |||
| process.env.NEXT_PUBLIC_WP_HOME_URL, | |||
| process.env.NEXT_PUBLIC_GRAPHQL_ENDPOINT | |||
| ) ]: { | |||
There was a problem hiding this comment.
This whole things is getting too messy, and not just because I hate the generate() function.
justlevine
reviewed
Apr 11, 2025
.changeset/cold-cows-joke.md
Outdated
| "@snapwp/core": patch | ||
| --- | ||
|
|
||
| feat: use SITE_URL for GraphQL endpoint instead of HOME_URL |
There was a problem hiding this comment.
This is a fix not a feature.
Suggested change
| feat: use SITE_URL for GraphQL endpoint instead of HOME_URL | |
| fix: use NEXT_PUBLIC_SITE_URL for GraphQL endpoint when available. |
justlevine
changed the title
SITE_URL for GraphQL endpoint instead of HOME_URLSITE_URL for GraphQL endpoint instead of HOME_URL
This was referenced Apr 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR uses
SITE_URLfor GraphQL endpoint instead ofHOME_URLWhy
In a bedrock setup, the graphql server is at host:port/wp/graphql and host:port/wp is the WP SITE_URL whereas often the HOME_URL will be just host:port
Related Issue(s):
#149
How
Updated instances of generateGraphQLUrl() - passed SITE_URL instead of HOME_URL, per WPGraphQL’s logic.
Testing Instructions
Screenshots
Additional Info
Checklist
npm run changeset.