Smoke Tests #3
Draft
Smoke Tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some changes to be able to run smoke tests on docker. This is not really the correct way to run these tests, but it gives an example of some of the issues that you run into when testing: 1. The domain is normally set to zfin.org for the docker container. That can cause problems in tests and other places. Not sure of the best solution. Here, I manually set it to cell-mac.zfin.org and then configure /etc/hosts file to resolve that correctly. 2. There are references to NON_SECUREPORT and SECUREPORT. I'm not sure if those are necessary anymore. I don't think the current docker config exposes a non-secure port for the tomcat container.
Allow passing a java property -DsingleTest=<testname> to run just that test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes to be able to run smoke tests on docker. This is not really the correct way to run these tests, but it gives an example of some of the issues that you run into when testing:
The domain is normally set to zfin.org for the docker container. That can cause problems in tests and other places. Not sure of the best solution. Here, I manually set it to cell-mac.zfin.org and then configure /etc/hosts file to resolve that correctly.
There are references to NON_SECUREPORT and SECUREPORT. I'm not sure if those are necessary anymore or just historical artifacts. I don't think the current docker config exposes a non-secure port for the tomcat container.
The ant logic for setting "isproduction" is based on the DBNAME, which is zfindb by default for docker--so "isproduction" gets set to true. I changed some logic so I could run 'ant -Disproduction=false runSmokeTests'. Though, there might be a better way of doing this.