Zfin 8317: publications page variations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtaylorzfin
commented
Nov 23, 2022
rtaylorzfin
commented
Nov 23, 2022
rtaylorzfin
commented
Nov 23, 2022
rtaylorzfin
commented
Nov 23, 2022
| <c:if test="${empty navigationMenu}"> | ||
| <c:forEach var="section" items="${sections}" varStatus="loop"> | ||
| <z:navigationItem title="${section}" | ||
| useNavigationCounter="${useNavigationCounter}" |
There was a problem hiding this comment.
probably could remove this and just use the navigationMenu properties
rtaylorzfin
commented
Nov 23, 2022
rtaylorzfin
commented
Nov 23, 2022
| protected List<NavigationItem> navigationItems; | ||
| protected boolean root = false; | ||
|
|
||
| public NavigationMenu(NavigationItem.NavigationItemBuilder ...navigationItemBuilders) { |
There was a problem hiding this comment.
should this be a constructor? Maybe a static fromBuilders method?
rtaylorzfin
commented
Nov 23, 2022
|
|
||
| /** | ||
| * Determine which sections to include based on each Menu Item's properties (isRequireRoot, isHidden, etc.) | ||
| * @return |
There was a problem hiding this comment.
flesh out these javadocs
rtaylorzfin
commented
Nov 23, 2022
| return include(option.toString()); | ||
| } | ||
|
|
||
| public boolean include(String option) { |
Introduce navigation based on a NavigationMenu class with subclass PublicationNavigationMenu for publication-view page. Use the same class to handle the logic of when to show various navigation items / sections and their counts. Hide errata if no errata. Styling changes: - align numbers to the right - change the border Add option for a feature flag to be enabled by default.
rtaylorzfin
force-pushed
the
zfin-8317
branch
from
e829d03 to
7de3475
Compare
Use the parentheses style of showing numbers without the pill shape. Expand the width of the left navigation, but only for publication pages.
Fix linting issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.