Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace proc-macro-error with proc-macro-error2 #979

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Replace proc-macro-error with proc-macro-error2 #979

merged 1 commit into from
Sep 29, 2024

Conversation

Sympatron
Copy link
Contributor

proc-macro-error depends on syn 1.0 and is no longer maintained. This PR replaces it with the drop-in replacement proc-macro-error2.

korken89
korken89 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@korken89 korken89 added this pull request to the merge queue Sep 29, 2024
Merged via the queue into rtic-rs:master with commit 7b534b3 Sep 29, 2024
55 checks passed
@Sympatron
Copy link
Contributor Author

I just looked into it again and realized that proc-macro-error wasn't even used anymore. It was only in the Cargo.toml and some Cargo.lock files.
So removing it altogether would be even better. Should I submit a new PR?

onsdagens pushed a commit to onsdagens/rtic that referenced this pull request Sep 30, 2024
@Sympatron @onsdagens
Replace proc-macro-error with proc-macro-error2 (rtic-rs#979)
3f94b9e
@AfoHT
Copy link
Contributor

AfoHT commented Oct 2, 2024

Should I submit a new PR?

Yes please, that would be appreciated! :D

@AfoHT AfoHT linked an issue Oct 2, 2024 that may be closed by this pull request
RUSTSEC-2024-0370: proc-macro-error is unmaintained #976
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korken89 korken89 korken89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0370: proc-macro-error is unmaintained
3 participants
@Sympatron @AfoHT @korken89