[monotonics] Fix STM32 read-modify-write race condition #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SR` register for STM32 clears when writing a zero to a bit. Therefore, all registers that should not be cleared need to be `1`. `modify` here caused a read-modify-write error that could clear unrelated flags.
Closed
Finomnis
force-pushed
the
fix_stm32_monotonic
branch
from
a8e467b to
185bf36
Compare
|
Needs testing on target. |
|
This might be enough of a bug to yank previous |
|
LGTM thank for fixing! Have this been tested on HW? |
Not by me yet. |
|
Ping me when ready and I'll prepare a release. |
|
@korken89 Runs realiably in debug but crashes immediately in release. Something is wrong with the init code, give me a second. |
|
@korken89 Seems like that fixed it. |
Finomnis
force-pushed
the
fix_stm32_monotonic
branch
2 times, most recently
from
2b3331a to
e752d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SRregister for STM32 clears when writing a zero to a bit. Therefore, all registers that should not be cleared need to be1.modifyhere caused a read-modify-write error that could clear unrelated flags.Related: libopencm3/libopencm3#392
Fixes: #956