#fix REQREPLY-221: Update RPC examples #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alive by the time we call finalize factory
albertorobles2000
changed the title
|
@alexcamposruiz I have apply the feedback and retarget the PR as you mentioned in the previous PR |
albertorobles2000
changed the title
2 tasks
This reverts commit ae0e3c1.
jmuros-rti
requested changes
Nov 7, 2024
tests/examples/connext_dds/dynamic_data_nested_structs/java/DynamicDataNestedStruct.sh
Show resolved
Hide resolved
tests/examples/connext_dds/request_reply/quack_files/request_reply_example_test_01.ti.yml
Show resolved
Hide resolved
jmuros-rti
previously approved these changes
Nov 7, 2024
Alxe
requested changes
Nov 7, 2024
tests/examples/connext_dds/request_reply/py/primes_requester.sh
Outdated
Show resolved
Hide resolved
Alxe
previously approved these changes
Nov 7, 2024
alexcamposruiz
requested changes
Nov 7, 2024
albertorobles2000
dismissed stale reviews from Alxe and jmuros-rti
via
aa5cc56
Alxe
approved these changes
Nov 8, 2024
acmrti
approved these changes
Nov 12, 2024
jmuros-rti
approved these changes
Nov 12, 2024
alexcamposruiz
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this PR we want to update RPC examples to use wait for service
Details and comments
I have also updated the examples so they finish at some point, we need it to test them
Checks