Optimize single thread work pool running srtrategy #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarmshine
requested changes
Apr 7, 2021
| @@ -15,7 +15,7 @@ private WorkPoolRunningStrategies() { | |||
|
|
|||
| @NotNull | |||
| public static WorkPoolRunningStrategy getSingleThreadStrategy() { | |||
| return localWorkPool -> 1; | |||
| return localWorkPool -> localWorkPool.isEmpty()? 0 : 1; | |||
There was a problem hiding this comment.
Could you please provide test when
- we start DJM with single job that has empty work pool
- work pool of the job is changed to non-empty
Expecting:
- job is not launched, from metrics we see that job did not started and we see that there is empty workpool for it
- number of threads changed correctly, job is launched, metrics are recorded
That kind of test and metrics will ensure that we can detect reason that job did not started due to empty workPool and also can be sure that 0 number of threads does not kill our scheduller.
There was a problem hiding this comment.
threadsCount = Math.max(threadsCount, 1); should save us, but better to have a test case for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.