BotSession - logs reducing #1466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenlagus
reviewed
Dec 30, 2024
| @@ -117,7 +117,7 @@ private ScheduledFuture<?> createPollerTask() throws TelegramApiException { | |||
| } | |||
| } catch (TelegramApiErrorResponseException e) { | |||
| long backOffMillis = backOff.nextBackOffMillis(); | |||
| log.error("Error received from Telegram GetUpdates Request, retrying in {} millis...", backOffMillis, e); | |||
| log.error("Error received from Telegram GetUpdates Request, retrying in {} millis...", backOffMillis); | |||
There was a problem hiding this comment.
If not printing the full stacktrace, it can be helpful if we print at least the response from telegram or the actual error why we are retrying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With long polling and not good network in logs can be a lot of messages with stacktrace. But enough only message, no stacktrace