Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find-by-memoization section #358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1131,6 +1131,28 @@ The following methods behave differently without `all`:

So, when considering removing `all` from the receiver of these methods, it is recommended to refer to the documentation to understand how the behavior changes.

=== `find_by` memoization [[find-by-memoization]]

Avoid memoizing `find_by` results with `||=`.
`find_by` may return `nil`, in which case it will not be memoized as intended.

[source,ruby]
----
# bad
def current_user
@current_user ||= User.find_by(id: session[:user_id])
end

# good
def current_user
if instance_variable_defined?(:@current_user)
@current_user
else
@current_user = User.find_by(id: session[:user_id])
end
end
----

== Migrations

=== Schema Version [[schema-version]]
Expand Down