Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caller: use lonely operator to safely call #first #476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chastell
Copy link
Contributor

@chastell chastell commented Nov 2, 2024

The Caller cop currently replaces caller[42] with caller(43..43).first.

If the caller stack is short, the former returns nil while the latter raises a NoMethodError (undefined method `first' for nil).

This PR fixes this by using the lonely operator (&.) to call #first only if the result is non-nil.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant