Fix false negatives for Rails/RedundantActiveRecordAllMethod when using POSSIBLE_ENUMERABLE_BLOCK_METHODS in a block
#1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masato-bkn
changed the title
Rails/RedundantActiveRecordAllMethod when m…Rails/RedundantActiveRecordAllMethod when using POSSIBLE_ENUMERABLE_BLOCK_METHODS in a block
masato-bkn
force-pushed
the
fix-redundant_active_record_all_method
branch
4 times, most recently
from
a97f810
to
b8a039a
Compare
koic
reviewed
Oct 29, 2024
| @@ -174,7 +174,7 @@ def possible_enumerable_block_method?(node) | |||
| parent = node.parent | |||
| return false unless POSSIBLE_ENUMERABLE_BLOCK_METHODS.include?(parent.method_name) | |||
|
|
|||
| parent.parent&.block_type? || parent.parent&.numblock_type? || parent.first_argument&.block_pass_type? | |||
| parent.block_node || parent.first_argument&.block_pass_type? | |||
There was a problem hiding this comment.
block_node doesn't return a boolean value for predicate method. block_literal? seems more appropriate.
Suggested change
| parent.block_node || parent.first_argument&.block_pass_type? | |
| parent.block_literal? || parent.first_argument&.block_pass_type? |
There was a problem hiding this comment.
Thank you for your review! I've fixed some issues.
koic
reviewed
Oct 29, 2024
| @@ -0,0 +1 @@ | |||
| * [#1382](https://github.com/rubocop/rubocop-rails/pull/1382): Fix false negatives for `Rails/RedundantActiveRecordAllMethod`. ([@masato-bkn][]) | |||
There was a problem hiding this comment.
The change log could use a bit more information. For example, something like the following:
Suggested change
| * [#1382](https://github.com/rubocop/rubocop-rails/pull/1382): Fix false negatives for `Rails/RedundantActiveRecordAllMethod`. ([@masato-bkn][]) | |
| * [#1382](https://github.com/rubocop/rubocop-rails/pull/1382): Fix false negatives for `Rails/RedundantActiveRecordAllMethod` when using `all` method in block. ([@masato-bkn][]) |
masato-bkn
force-pushed
the
fix-redundant_active_record_all_method
branch
from
b8a039a
to
e42189c
Compare
…sing `all` method in block
This PR fixes false negatives for `Rails/RedundantActiveRecordAllMethod` when methods in `POSSIBLE_ENUMERABLE_BLOCK_METHODS` are used in a block as following:
```
expect { subject }.to change { User.all.count }
```
masato-bkn
force-pushed
the
fix-redundant_active_record_all_method
branch
from
e42189c
to
2d7e7a0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes false negatives for
Rails/RedundantActiveRecordAllMethodwhen methods inPOSSIBLE_ENUMERABLE_BLOCK_METHODSare used in a block.Expected Behavior
Actual Behavior
No offenses are registered.
Steps to reproduce the problem
Run
bundle ex rubocop --only Rails/RedundantActiveRecordAllMethodon the code below:RuboCop version
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.