[Fix #1356] Enhance Rails/DuplicateAssociation to handle alias
#1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydakuka
changed the title
Rails/DuplicateAssociation to handle alias
ydakuka
force-pushed
the
fix/enhance-rails-duplicate-association-to-handle-alias
branch
3 times, most recently
from
f533ea0 to
af4b9f7
Compare
ydakuka
force-pushed
the
fix/enhance-rails-duplicate-association-to-handle-alias
branch
from
af4b9f7 to
10829d3
Compare
koic
reviewed
Jan 20, 2025
| belongs_to :foo | ||
| belongs_to :bar |
There was a problem hiding this comment.
Although this change caught my attention, the later definition takes precedence, so let's proceed with this for now.
ydakuka
deleted the
fix/enhance-rails-duplicate-association-to-handle-alias
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1356
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.