Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #49] Add new Rails/RescueFromExceptionsVariableName cop #1440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ydakuka
Copy link
Contributor

@ydakuka ydakuka commented Feb 15, 2025

Fixes #49
Based on #139

Ensures that rescued exception variables are named as expected.

The PreferredName config option specifies the required name of the variable.
Its default is e, as referenced from Naming/RescuedExceptionsVariableName.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@ydakuka ydakuka changed the title [Fix rubocop#49] Add new Rails/RescueFromExceptionsVariableName cop [Fix #49] Add new Rails/RescueFromExceptionsVariableName cop Feb 15, 2025
@ydakuka ydakuka force-pushed the 49-rescued_exception_variable_name branch from b7c698b to 8eaea82 Compare February 15, 2025 13:46
Ensures that rescued exception variables are named as expected.

The `PreferredName` config option specifies the required name of the variable.
Its default is `e`, as referenced from `Naming/RescuedExceptionsVariableName`.
@ydakuka ydakuka force-pushed the 49-rescued_exception_variable_name branch from 8eaea82 to 0363212 Compare February 17, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle RescuedExceptionsVariableName with rescue_from
1 participant