Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rspec/ExampleWording handle Unicode RIGHT SINGLE QUOTATION MARK #1935

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

jdufresne
Copy link
Contributor

Some people and editors write contractions such as "shouldn't" and "won't" using the Unicode RIGHT SINGLE QUOTATION MARK, "shouldn’t" and "won’t" so make Rspec/ExampleWording understand this alternative spelling.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation. N/A
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Some people and editors write contractions such as "shouldn't" and
"won't" using the Unicode RIGHT SINGLE QUOTATION MARK, "shouldn’t" and
"won’t" so make Rspec/ExampleWording understand this alternative
spelling.
@jdufresne jdufresne requested a review from a team as a code owner July 8, 2024 17:29
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@pirj pirj requested a review from a team July 8, 2024 18:17
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

@ydah ydah merged commit aa734b0 into rubocop:master Jul 9, 2024
24 checks passed
@koic koic mentioned this pull request Jul 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants