Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActiveSupport class_attribute detection #35

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

viralpraxis
Copy link
Collaborator

@viralpraxis viralpraxis commented Sep 7, 2024

Resolves #34

@viralpraxis
Copy link
Collaborator Author

viralpraxis commented Sep 7, 2024

It seems like failures are unrelated to these changes. Should be fixed by pushing rubocop -A and rake generate_cops_documentation to master:

diff --git a/docs/modules/ROOT/pages/cops_threadsafety.adoc b/docs/modules/ROOT/pages/cops_threadsafety.adoc
index c2e613a..e6cba0c 100644
--- a/docs/modules/ROOT/pages/cops_threadsafety.adoc
+++ b/docs/modules/ROOT/pages/cops_threadsafety.adoc
@@ -114,7 +114,7 @@ end
 
 | Enabled
 | Yes
-| Yes (Unsafe)
+| Always (Unsafe)
 | -
 | -
 |===
diff --git a/spec/rubocop/thread_safety_spec.rb b/spec/rubocop/thread_safety_spec.rb
index 544495b..7f84972 100644
--- a/spec/rubocop/thread_safety_spec.rb
+++ b/spec/rubocop/thread_safety_spec.rb
@@ -2,6 +2,6 @@
 
 RSpec.describe RuboCop::ThreadSafety do
   it 'has a version number' do
-    expect(RuboCop::ThreadSafety::VERSION).not_to be nil
+    expect(RuboCop::ThreadSafety::VERSION).not_to be_nil
   end
 end
(END)

Fixed (probably) by #37, feel free to close if I'm wrong

@viralpraxis viralpraxis force-pushed the yk/remove-class-attribute-cop branch from 6228984 to 9899b3d Compare September 7, 2024 19:42
@mikegee mikegee merged commit b59002b into rubocop:master Sep 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify class_attribute thread safety
2 participants