Fix CI #400
Merged
Fix CI #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main branch is `main`, not `master`. This change is required to trigger GithubActions on each push to the `main` branch.
Removes the next message from RSpec output: ``` ** [Bugsnag] 2024-08-25 16:46:45 +0100: Notifying https://notify.bugsnag.com of RuntimeError ```
Removes the next message from RSpec output: ``` E, [2024-08-25T18:20:18.087844 #62797] ERROR -- ddtrace: [ddtrace] (gems/ddtrace-1.23.3/lib/datadog/tracing/transport/http/client.rb:41:in `rescue in send_request') Internal error during Datadog::Tracing::Transport::HTTP::Client request. Cause: Errno::ECONNREFUSED Failed to open TCP connection to 127.0.0.1:8126 (Connection refused - connect(2) for "127.0.0.1" port 8126) Location: /lib/ruby/2.7.0/net/http.rb:960:in `initialize' ```
Error handling specs were broken since `c66dc7139a467ef9398c86f1aca6f65ee83c59bc` as the RSpec stubs methods with arity `-1` causing the next exception: ``` Failure/Error: backend.handle *args.first(backend.method(:handle).arity) ArgumentError: negative array size ``` This commit fixes the error to skipping stubbing and testing the result (log output). Also it adds a couple of specs to ensure error handlers for support of delivery_info
michaelklishin
approved these changes
Aug 26, 2024
|
@sharshenov sweet, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tests fail and contain a noise in the output. Example
Solution
This PR contains a few changes to fix the CI
master(by the way the main branch in the repo ismain, notmaster)