Remove upper dependency version limit on activesupport #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of Rails 8.0.0.1 the dependency update I made as part of ruby-amqp#402 is too strict and the gem gets downgraded to version 0.23.1. It might be better to remove the upper ceiling on `activesupport` so this doesn't become a recurring blocker for future rails releases
|
@drobny thank you! Do we need a new urgent-ish release? I assume a new Rails major can result in a non-trivial wave of upgrades? |
@michaelklishin that would be amazing if you could 🙏 |
michaelklishin
added a commit
that referenced
this pull request
Dec 11, 2024
…activesupport Remove upper dependency version limit on activesupport (cherry picked from commit b980876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Rails 8.0.0.1 the dependency update I made as part of #402 is too strict and the gem gets downgraded to version 0.23.1 as part of a rails upgrade
It might be better to remove the upper ceiling on
activesupportso this doesn't become a recurring blocker for future rails releases