Fix infinite loop problem with the NameErrors in block exposures
#355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `NameError#message` causes the `did_you_mean` library to endup being in an infinite loop(Probabaly raises `SystemStackError` at some point though). Related to ruby/did_you_mean#158
|
@dblock Would you mind taking a look at this? |
|
@meinac … which ruby version cause this bad behaviour? |
|
ah ok, want to ensure it fails on a supported version 🙂 please, can you fix the rubocop stuff – yeap, you don't introduced it … |
|
@LeFnord I've addressed the Rubocop failure by 9f58f29. BTW, this is not a conflict with the Thanks in advance for any help you can offer on this. Also, thanks @Quintasan for your quick answer. |
|
thanks @meinac for fixing it |
|
Hi @LeFnord, do you have a plan to release a new version containing this fix? |
|
yeap, today, see #356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
NameError#messagecauses thedid_you_meanlibrary to endupbeing in an infinite loop(Probabaly raises
SystemStackErrorat somepoint though).
Related to ruby/did_you_mean#158