Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inspect method to handle nil serializable_hash #384

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update inspect method to handle nil serializable_hash #384

wants to merge 3 commits into from
+14 −3

Conversation

fcce
Copy link

@fcce fcce commented Apr 28, 2024

serializable_hash may return nil

before

Entities::User.represent nil
# An error occurred when inspecting the object: #<NoMethodError: undefined method `map' for nil:NilClass>

after

Entities::User.represent nil
#<Entities::User:326200 nil>

dblock
dblock requested changes May 2, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test and update CHANGELOG please?

@fcce fcce force-pushed the ce/serializable_hash_nil branch from 5be9bba to a68b90d Compare May 6, 2024 06:56
@fcce fcce requested a review from dblock May 6, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock Awaiting requested review from dblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcce @dblock