Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP Basic Authentication #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VasylShevchenko
Copy link

No description provided.

@dblock
Copy link
Member

dblock commented Oct 26, 2019

I'd expect username/password to be nil by default and blank being a valid value, at least for the password.

This needs tests and CHANGELOG entry.

@dblock
Copy link
Member

dblock commented Oct 26, 2019

I am not sure we want this. There's many ways to do auth and you can do basic auth outside of this controller when mounting it into an existing Rails application, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants