Fix params method redefined warnings

Activate warnings in specs
ruby-grape · Jan 6, 2024 · d0cda67 · d0cda67
1 parent 3d85058
commit d0cda67
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.rspec b/.rspec
@@ -2,3 +2,4 @@
 --color
 --format=documentation
 --order=rand
+--warnings
diff --git a/lib/grape/router/greedy_route.rb b/lib/grape/router/greedy_route.rb
@@ -13,7 +13,8 @@ class GreedyRoute
 
       attr_reader :index, :pattern, :options, :attributes
 
-      delegate Grape::Router::AttributeTranslator::ROUTE_ATTRIBUTES => :@attributes
+      # params must be handled in this class to avoid method redefined warning
+      delegate Grape::Router::AttributeTranslator::ROUTE_ATTRIBUTES - [:params] => :@attributes
 
       def initialize(index:, pattern:, **options)
         @index = index

diff --git a/lib/grape/router/route.rb b/lib/grape/router/route.rb
@@ -13,7 +13,8 @@ class Route
       attr_accessor :index
 
       def_delegators :pattern, :path, :origin
-      delegate Grape::Router::AttributeTranslator::ROUTE_ATTRIBUTES => :attributes
+      # params must be handled in this class to avoid method redefined warning
+      delegate Grape::Router::AttributeTranslator::ROUTE_ATTRIBUTES - [:params] => :attributes
 
       def initialize(method, pattern, **options)
         @options = options