Align error! method signatures across different places.

[numbata]

This pull request fix a compatibility issue with the error! method when used in rescue_from block.

Previously, the rescue_from block ran in context of Grape::Middleware::Error, where error! method had one signature. Now, block run in context of Grape::DSL::InsideRoute, where error! method has different signature. This change cause runtime errors when error! method was called with extra arguments like backtrace and original_exception.

This update make error! method signatures same across different contexts. By aligning these signatures, error! method can handle additional arguments consistently and preventing errors.

[numbata]

The 2eabc9b is on top the commit before the 2377 PR was merged. And it passes now.

[numbata]

The branch was rebased from the master and the spec are failing now with:

$ bundle exec rspec spec/grape/api_spec.rb:2541
Run options: include {:locations=>{"./spec/grape/api_spec.rb"=>[2541]}}

Randomized with seed 55390

Grape::API
  .error_format
    class
      returns a modified error  with a custom error format (FAILED - 1)

Failures:

  1) Grape::API.error_format class returns a modified error  with a custom error format
     Failure/Error:
       def error!(message, status = nil, additional_headers = nil)
         status = self.status(status || namespace_inheritable(:default_error_status))
         headers = additional_headers.present? ? header.merge(additional_headers) : header
         throw :error, message: message, status: status, headers: headers

     ArgumentError:
       wrong number of arguments (given 5, expected 1..3)
     # ./lib/grape/dsl/inside_route.rb:168:in `error!'
     # ./spec/grape/api_spec.rb:2538:in `block (5 levels) in <top (required)>'
     # ./lib/grape/middleware/error.rb:120:in `instance_exec'
     # ./lib/grape/middleware/error.rb:120:in `block in run_rescue_handler'
     # ./lib/grape/middleware/error.rb:119:in `catch'
     # ./lib/grape/middleware/error.rb:119:in `run_rescue_handler'
     # ./lib/grape/middleware/error.rb:36:in `rescue in call!'
     # ./lib/grape/middleware/error.rb:32:in `call!'
     # ./lib/grape/middleware/base.rb:27:in `call'
     # ./lib/grape/endpoint.rb:225:in `call!'
     # ./lib/grape/endpoint.rb:219:in `call'
     # ./lib/grape/router/route.rb:19:in `exec'
     # ./lib/grape/router.rb:121:in `process_route'
     # ./lib/grape/router.rb:68:in `block in identity'
     # ./lib/grape/router.rb:101:in `transaction'
     # ./lib/grape/router.rb:66:in `identity'
     # ./lib/grape/router.rb:50:in `block in call'
     # ./lib/grape/router.rb:137:in `with_optimization'
     # ./lib/grape/router.rb:49:in `call'
     # ./lib/grape/api/instance.rb:164:in `call'
     # ./lib/grape/api/instance.rb:68:in `call!'
     # ./lib/grape/api/instance.rb:63:in `call'
     # ./lib/grape/api.rb:78:in `call'
     # ./spec/grape/api_spec.rb:2544:in `block (4 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # RuntimeError:
     #   rain!
     #   ./spec/grape/api_spec.rb:2542:in `block (5 levels) in <top (required)>'

Finished in 0.01702 seconds (files took 0.56084 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/grape/api_spec.rb:2536 # Grape::API.error_format class returns a modified error  with a custom error format

Randomized with seed 55390

Coverage report generated for RSpec to ./grape/coverage. 2039 / 3670 LOC (55.56%) covered.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected

[dblock]

Looks good!

[numbata]

@dblock any plans for release this?

[dblock]

I can do it this week unless @ericproulx or another maintainer wants to beat me to it?

[numbata]

Just a quick reminder!
The Renovate bot is eager to update our dependencies (including grape), but we're holding off until these changes will be published.

[dblock]

Andrei, it will get done when it will get done. No reminders needed. Your company is welcome to hire any of the maintainers of grape to do it on your schedule, or at least sponsor the project.

[numbata]

Andrei, it will get done when it will get done.

No pressure! And I would be happy to hire or sponsor any or all of the maintainers, but I hope I can contribute in other ways as well. By my PR's for example.

[numbata]

Off topic about sponsoring the project: I was looking for an easy way to enter my credit card information and set up a monthly "buy a couple of coffees for grape maintainers" donation. But it's not very clear to me where to do that on the Tidelift page. So I just gave up.

[dblock]

Appreciate it. I do have a sponsor profile :)

[ericproulx]

@numbata Grape 2.1.3 is out :) Thank you for your patience.