Merge pull request #176 from makketagg/fix/variable-name-corrections-…

…duplicates Fixed correction duplicates in VaribaleNameChecker
ruby · Sep 1, 2022 · c629aef · c629aef
2 parents 9dce63d + c3fc412
commit c629aef
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb b/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb
@@ -79,7 +79,7 @@ def initialize(exception)
     def corrections
       @corrections ||= SpellChecker
                      .new(dictionary: (RB_RESERVED_WORDS + lvar_names + method_names + ivar_names + cvar_names))
-                     .correct(name) - NAMES_TO_EXCLUDE[@name]
+                     .correct(name).uniq - NAMES_TO_EXCLUDE[@name]
     end
   end
 end
diff --git a/test/spell_checking/test_variable_name_check.rb b/test/spell_checking/test_variable_name_check.rb
@@ -137,4 +137,16 @@ def test_exclude_typical_incorrect_suggestions
     error = assert_raise(NameError){ foo }
     assert_empty error.corrections
   end
+
+  def test_exclude_duplicates_with_same_name
+    error = assert_raise(NameError) do
+      eval(<<~RUBY, binding, __FILE__, __LINE__)
+        bar = 1
+        def bar;end
+        zar
+      RUBY
+    end
+
+    assert_correction [:bar], error.corrections
+  end
 end