Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakefile: Manage test files by excluding test files in the test_fips task. #820

Conversation

junaruga
Copy link
Member

Until now, we have added 18 test files as target files executed in the test_fips task to the Rakefile. As there are total 33 test files, more than 50% (= 18/33) of the test files have been added.

Now I want to manage the test files in the test_fips task by excluding test files rather than adding the target test files in the test_fips task. About the excluded test files, I mentioned at #603 (comment).

My motivations for this change are

  1. We can test FIPS cases for the test files to be added in the future.
  2. We can clarify the remaining failing test files that we need to fix.

…task.

Manage test files by excluding test files rather than adding the target test
files in the test_fips task.

My motivations for this change are
1. We can test FIPS cases for the test files to be added in the future.
2. We can clarify the remaining failing test files that we need to fix.
@junaruga
Copy link
Member Author

As a test for this PR, below is the CI test result in OpenSSL master fips on the latest master branch.

https://github.com/ruby/openssl/actions/runs/11959473510/job/33341351372#step:11:453

249 tests, 1523 assertions, 0 failures, 0 errors, 2 pendings, 22 omissions, 0 notifications

And below is the CI test result in OpenSSL master fips on this PR. And both results are the same, and it is expected.

https://github.com/ruby/openssl/actions/runs/11973989540/job/33384106630?pr=820#step:11:453

249 tests, 1523 assertions, 0 failures, 0 errors, 2 pendings, 22 omissions, 0 notifications

Copy link
Member

@rhenium rhenium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good way forward, and as far as I understand the plan is to eventually make rake test compatible with it. Thanks!

@rhenium rhenium merged commit 6701d5e into ruby:master Nov 22, 2024
59 checks passed
@junaruga junaruga deleted the wip/fips-manage-test-files-with-excluded-test-files branch November 22, 2024 17:11
@junaruga
Copy link
Member Author

junaruga commented Nov 22, 2024

That sounds like a good way forward, and as far as I understand the plan is to eventually make rake test compatible with it. Thanks!

Yes. Your understanding is right. Eventually we will make the rake test compatible with FIPS cases, or the rake test and rake test_fips calls an internal common logic.

Thanks for your reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants