Reenable JRuby for testing #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRuby's recent issues with jar-dependencies caused installs to fail, but those issues have been resolved as of JRuby 9.4.12.0 (and by extension, jruby-head). Reverts part of ruby#1228.
This is temporary until jruby/jruby#8672 can be addressed.
|
This should be ready to merge. I filed a JRuby issue for the Windows failure: jruby/jruby#8672. When that's addressed I'll reenable Windows CI for JRuby. |
|
@headius Thanks! |
|
There seems to be intermittent failing on ubuntu now (example). Can you give it a look? |
|
@st0012 At a glance I'd suspect the test is flawed, since execution of this code should not suddenly go non-linear after being linear previously. It seems like the harness could be made more robust, or could exercise the code more before attempting to measure tiny timeouts. At these small intervals, even the JVM JIT kicking in could cause us to slow down temporarily and unpredictably. I will try to see if there's something actually broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby's recent issues with jar-dependencies caused installs to fail, but those issues have been resolved as of JRuby 9.4.12.0 (and by extension, jruby-head).
Reverts part of #1228.
Previous PR #1229 seemed to get messed up so I'm re-pushing here.