Use loop instead of recursive call for Element#namespace

It's for performance and avoiding stack level too deep.
ruby · Aug 17, 2024 · fdbffe7 · fdbffe7
1 parent 6422fa3
commit fdbffe7
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/rexml/element.rb b/lib/rexml/element.rb
@@ -624,8 +624,12 @@ def namespace(prefix=nil)
       else
         prefix = "xmlns:#{prefix}" unless prefix[0,5] == 'xmlns'
       end
-      ns = attributes[ prefix ]
-      ns = parent.namespace(prefix) if ns.nil? and parent
+      ns = nil
+      target = self
+      while ns.nil? and target
+        ns = target.attributes[prefix]
+        target = target.parent
+      end
       ns = '' if ns.nil? and prefix == 'xmlns'
       return ns
     end