Add local entity expansion limit methods #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naitoh
force-pushed
the
add_local_entity_expansion_limit
branch
from
4d41134
to
f49740a
Compare
naitoh
force-pushed
the
add_local_entity_expansion_limit
branch
from
f49740a
to
8554f73
Compare
kou
reviewed
Aug 23, 2024
lib/rexml/document.rb
Outdated
| raise "number of entity expansions exceeded, processing aborted." | ||
| end | ||
| end | ||
|
|
||
| def entity_expansion_limit=( limit ) |
There was a problem hiding this comment.
How about using attr_writer :entity_expansion_limit?
| @@ -431,14 +433,19 @@ def Document::entity_expansion_text_limit | |||
| end | |||
|
|
|||
| attr_reader :entity_expansion_count | |||
| attr_accessor :entity_expansion_text_limit | |||
There was a problem hiding this comment.
Yes
In the following we use reader.
- https://github.com/naitoh/rexml/blob/baeec861d8687c1a6ddc86a699347048348ce896/lib/rexml/text.rb#L271-L272
entity_expansion_text_limit =
document&.entity_expansion_text_limit || Security.entity_expansion_text_limit - https://github.com/naitoh/rexml/blob/baeec861d8687c1a6ddc86a699347048348ce896/lib/rexml/attribute.rb#L152-L154
entity_expansion_text_limit =
@element&.document&.entity_expansion_text_limit ||
Security.entity_expansion_text_limit - https://github.com/naitoh/rexml/blob/baeec861d8687c1a6ddc86a699347048348ce896/lib/rexml/entity.rb#L78-L79
entity_expansion_text_limit =
document&.entity_expansion_text_limit || Security.entity_expansion_text_limit
naitoh
force-pushed
the
add_local_entity_expansion_limit
branch
from
8554f73
to
baeec86
Compare
kou
reviewed
Aug 26, 2024
## Why? See: ruby#192 --------- Co-authored-by: Sutou Kouhei <[email protected]>
## Why? See: ruby#192 --------- Co-authored-by: Sutou Kouhei <[email protected]>
naitoh
force-pushed
the
add_local_entity_expansion_limit
branch
from
baeec86
to
d732ec2
Compare
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: fix GH-192
Add local entity expansion limit methods.
REXML::Document#entity_expansion_limit=REXML::Document#entity_expansion_text_limit=REXML::Parsers::SAX2Parser#entity_expansion_limit=REXML::Parsers::SAX2Parser#entity_expansion_text_limit=REXML::Parsers::StreamParser#entity_expansion_limit=REXML::Parsers::StreamParser#entity_expansion_text_limit=REXML::Parsers::PullParser#entity_expansion_limit=REXML::Parsers::PullParser#entity_expansion_text_limit=