Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for Time.new #1038

Merged
merged 1 commit into from
May 23, 2023
Merged

Add specs for Time.new #1038

merged 1 commit into from
May 23, 2023

Conversation

moozzi
Copy link
Contributor

@moozzi moozzi commented May 19, 2023

#1016
[Feature #18033]

Time.new now can parse a string like generated by Time#inspect
and return a Time instance based on the given argument.

@moozzi moozzi marked this pull request as ready for review May 19, 2023 13:41
andrykonchin
andrykonchin approved these changes May 19, 2023
View reviewed changes
core/time/new_spec.rb Show resolved Hide resolved
core/time/new_spec.rb Outdated Show resolved Hide resolved
core/time/new_spec.rb Outdated Show resolved Hide resolved
core/time/new_spec.rb Outdated Show resolved Hide resolved
core/time/new_spec.rb Show resolved Hide resolved
core/time/new_spec.rb Outdated Show resolved Hide resolved
core/time/new_spec.rb Outdated Show resolved Hide resolved
core/time/new_spec.rb Outdated Show resolved Hide resolved
core/time/new_spec.rb Show resolved Hide resolved
@moozzi moozzi force-pushed the add_specs_for_time_new branch from 237a314 to 70c5f26 Compare May 23, 2023 08:42
andrykonchin
andrykonchin reviewed May 23, 2023
View reviewed changes
core/time/new_spec.rb Outdated Show resolved Hide resolved
core/time/new_spec.rb Show resolved Hide resolved
core/time/new_spec.rb Show resolved Hide resolved
@moozzi moozzi force-pushed the add_specs_for_time_new branch from 70c5f26 to ce0c6e6 Compare May 23, 2023 13:12
@andrykonchin andrykonchin changed the title Add specs for Time#new Add specs for Time.new May 23, 2023
@andrykonchin
Copy link
Member

Thank you!

@andrykonchin andrykonchin merged commit d598249 into ruby:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrykonchin andrykonchin andrykonchin approved these changes

@eregon eregon eregon left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moozzi @andrykonchin @eregon