-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Persian Language #2175
base: master
Are you sure you want to change the base?
Add Persian Language #2175
Conversation
update repo
update repo
Repo Update
Update repo
update repo
Update Repo
Update Repo
Update Repo
Update Repo
Please rebase from the current master branch. We should ignore the Merge commit from master branch. |
First some general remarks: It should be certain before any PRs that there are enough maintainers/translators. Adding a new translation involves a lot of work, both in preparation and afterwards:
See also the milestones for #699 to get an impression of the work involved during the initial translation process, and the discussion #670. This may sound a little discouraging, but please keep in mind that a new translation causes a lot of work for us maintainers, too. As soon as it is sure that there is a team of at least say 3 persons who will show that kind of commitment, we can discuss the details on how to best proceed. Please do not provide PRs right now. Regarding this PR: even after a only cursory review there are several issues, like e.g. merge commits, or duplicated English content instead of translations, or added files that do not belong here at all, ..., and on the whole much too many changes, also changes of general configuration files or stylesheets that need extra care in reviewing and possibly some discussion. It cannot be merged. (Also, work in progress should not be merged into the master branch, since that's what gets deployed regularly.) |
I'll need to do some basic setup, then I'll open a new issue with milestones for tracking the progress. |
I'm in the process of improving some configuration setup, e.g. handling of locales data, which should be completed before starting on the new translation to avoid later merge conflicts. |
In the meantime, could the other contributors please leave a short comment here? And one general question beforehand: is it necessary to require a specific font? Other translations do not do that. |
Hey there, Sorry for my late respond, We had internet blackout since last week.
It is better to use standard fonts for better readability since the Persian language uses Arabic script. |
Hello, |
Hello, |
No description provided.