Ensure node has focus before setting value

Currently the javascript used to set a field value will trigger a "focus" event prior to updating a field however this does not set the input as focused so any use of `document.activeElement` will return the body element. To fix this a call to `node.focus()` has been added before the focus event to ensure `document.activeElement` will respond correctly.
rubycdp · Oct 29, 2024 · b390fde · b390fde
1 parent a58b22b
commit b390fde
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/lib/capybara/cuprite/javascripts/index.js b/lib/capybara/cuprite/javascripts/index.js
@@ -124,6 +124,7 @@ class Cuprite {
 
     let valueBefore = node.value;
 
+    node.focus();
     this.trigger(node, "focus");
     this.setValue(node, "");
 

diff --git a/spec/features/driver_spec.rb b/spec/features/driver_spec.rb
@@ -1534,6 +1534,19 @@ def create_screenshot(file, *args)
         end
       end
 
+      context "input_fields" do
+        before { @session.visit("/cuprite/input_fields") }
+
+        it "focuses the element when filling in the value" do
+          input = @session.find(:css, "#text_field")
+          @session.fill_in "text_field", with: "2016-02-14"
+
+          expect(@session.find(:css, "#text_field").value).to eq("2016-02-14")
+          node = @session.driver.evaluate_script("document.activeElement")
+          expect(node).to eq input
+        end
+      end
+
       context "evaluate_script" do
         it "can return an element" do
           @session.visit("/cuprite/send_keys")

diff --git a/spec/support/views/input_fields.erb b/spec/support/views/input_fields.erb
@@ -0,0 +1,9 @@
+<html xmlns="http://www.w3.org/1999/xhtml" lang="en">
+  <head>
+    <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
+  </head>
+
+  <body>
+    <input type="text" id="text_field" name="text_field"/>
+  </body>
+</html>