Fix request interception when using a black/whitelist #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve two issues:
The callback that applies the black/whitelist now:
I also question if continuing the request should be the callback's responsibility or not, or if Ferrum should just continue it if no callbacks responded or aborted. As things stand, all callbacks need to do something like this.
Thank you so much for cuprite/ferrum, my test suites run faster, are easier to debug, and I actually understand what's going on and can read the code powering the entire stack. Awesome work ❤️