Show abstract, details, pitch diff in proposal #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrettclark
force-pushed
the
show-diffs
branch
from
6be3714 to
d6cfc3f
Compare
|
We decided to try this feature on our event. Just resolved the conflicts, and confirmed that the existing tests are passing. So, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've iterated a little on the proposal diff idea. I am trying to do the simplest possible
implementation and give us foundation to build from. The components of the diff
viewer are:
If there are updates to the
abstract,details, orpitchfields the diff viewerwill be displayed:
I would love feedback, and even help fine-tuning this and getting it in place.
This resolves #23