Let Room name be unique within each event #394
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatsuda
force-pushed
the
room_name_uniqueness_per_event
branch
from
03e4ee1 to
6bdd67a
Compare
amatsuda
force-pushed
the
room_name_uniqueness_per_event
branch
from
6bdd67a to
0e7ee21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rooms.name is constrained to be unique within the whole database, but in the real world, conference venues tend to name their room very similarly, for instance, "Room A, Room B, Room C..." or "101, 102, 103...". So we have to somehow workaround on cfp-app by prefixing or suffixing year or something.
I don't think there's any use case that requires the Room names to be unique across the years, thus this attribute doesn't have to be DB unique but should better be unique per event.