-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Cloud Foundry (cf) #161
base: master
Are you sure you want to change the base?
Conversation
👍 |
I will review it tomorrow. Could you in the meantime squash your commits? |
884cb77
to
137094e
Compare
Done 😄 |
711aa34
to
ca0391f
Compare
Signed-off-by: Natalie Tay <[email protected]> Signed-off-by: Alan Yeo <[email protected]> Signed-off-by: Benjamin Tan <[email protected]>
ca0391f
to
247119b
Compare
) | ||
|
||
out = '' | ||
dotted_hash = to_dotted_hash Kernel.const_get(Config.const_name).to_hash, {}, Config.const_name | ||
dotted_hash = to_dotted_hash Kernel.const_get(Config.const_name).to_hash, namespace: Config.const_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this now needs to be Object.const_get
@alanyjw you put a lot of work into this PR, unfortunatelly tests are failing. Do you wanna fix it? |
@pkuczynski I'll have a look when I find some time. |
Cool thanks! |
Here is an overview of what got changed by this pull request: Issues
======
+ Solved 8
- Added 88
Complexity increasing per file
==============================
- lib/config/integrations/helpers/cf_manifest_merger.rb 3
- lib/config/integrations/helpers/helpers.rb 5
Complexity decreasing per file
==============================
+ lib/config/integrations/heroku.rb -2
See the complete overview on Codacy |
@pkuczynski I tried cloning rubyconfig on my computer and follow the steps in CONTRIBUTING.md but when I run
For both this pull request and master. I use RVM and a dedicated gemset. Is there anything that jumps to your mind that I'm doing wrong? PS: I also did the same thing in a ruby:2.6 container; I've got the exact same result. |
No description provided.