Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cloud Foundry (cf) #161

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alanyjw
Copy link

@alanyjw alanyjw commented Dec 21, 2016

No description provided.

@gamov
Copy link

gamov commented Dec 21, 2016

👍

@pkuczynski
Copy link
Member

I will review it tomorrow. Could you in the meantime squash your commits?

@divyabhargov divyabhargov force-pushed the add-support-for-cf branch 3 times, most recently from 884cb77 to 137094e Compare December 27, 2016 03:28
@gamov
Copy link

gamov commented Jan 4, 2017

Done 😄

@gamov gamov force-pushed the add-support-for-cf branch from 711aa34 to ca0391f Compare January 13, 2017 07:08
Signed-off-by: Natalie Tay <[email protected]>
Signed-off-by: Alan Yeo <[email protected]>
Signed-off-by: Benjamin Tan <[email protected]>
@gamov gamov force-pushed the add-support-for-cf branch from ca0391f to 247119b Compare January 13, 2017 07:57
@rubyconfig rubyconfig deleted a comment Jun 22, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
@rubyconfig rubyconfig deleted a comment Jun 28, 2019
)

out = ''
dotted_hash = to_dotted_hash Kernel.const_get(Config.const_name).to_hash, {}, Config.const_name
dotted_hash = to_dotted_hash Kernel.const_get(Config.const_name).to_hash, namespace: Config.const_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this now needs to be Object.const_get

@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@rubyconfig rubyconfig deleted a comment Aug 6, 2019
@pkuczynski
Copy link
Member

@alanyjw @gamov are you still interested in this PR?

@pkuczynski
Copy link
Member

@alanyjw you put a lot of work into this PR, unfortunatelly tests are failing. Do you wanna fix it?

@gamov
Copy link

gamov commented Apr 1, 2020

@pkuczynski I'll have a look when I find some time.

@pkuczynski
Copy link
Member

Cool thanks!

@pkuczynski
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 8
- Added 88
           

Complexity increasing per file
==============================
- lib/config/integrations/helpers/cf_manifest_merger.rb  3
- lib/config/integrations/helpers/helpers.rb  5
         

Complexity decreasing per file
==============================
+ lib/config/integrations/heroku.rb  -2
         

See the complete overview on Codacy

@rubyconfig rubyconfig deleted a comment Jun 23, 2020
@gamov
Copy link

gamov commented Jun 30, 2020

@pkuczynski I tried cloning rubyconfig on my computer and follow the steps in CONTRIBUTING.md but when I run appraisal rspec I get the following error 12x:

>> BUNDLE_GEMFILE=/Users/gamov/Temp/@NoTM/config/gemfiles/rails_4.2.gemfile bundle exec rspec
RUBY_ENGINE: ruby
RUBY_VERSION: 2.6.5


An error occurred while loading ./spec/config_env_spec.rb. - Did you mean?
                    rspec ./spec/config_spec.rb

Failure/Error: require 'bootsnap/setup' # Speed up boot time by caching expensive operations.

LoadError:
  cannot load such file -- bootsnap/setup
# ./spec/app/rails_6.0/config/boot.rb:4:in `require'
# ./spec/app/rails_6.0/config/boot.rb:4:in `<top (required)>'
# ./spec/app/rails_6.0/config/application.rb:1:in `require_relative'
# ./spec/app/rails_6.0/config/application.rb:1:in `<top (required)>'
# ./spec/app/rails_6.0/config/environment.rb:2:in `require_relative'
# ./spec/app/rails_6.0/config/environment.rb:2:in `<top (required)>'
# ./spec/spec_helper.rb:36:in `require'
# ./spec/spec_helper.rb:36:in `<top (required)>'
# ./spec/config_env_spec.rb:1:in `require'
# ./spec/config_env_spec.rb:1:in `<top (required)>'
RUBY_ENGINE: ruby
RUBY_VERSION: 2.6.5

For both this pull request and master. I use RVM and a dedicated gemset. Is there anything that jumps to your mind that I'm doing wrong?
Thanks!

PS: I also did the same thing in a ruby:2.6 container; I've got the exact same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants