-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/heroku compatibility #64
Feature/heroku compatibility #64
Conversation
this is rad. i want this feature! cc @pkuczynski wdyt? |
@ssidelnikov sincere apologies I havent kept up on this |
Hi, any news on this? I'm trying to deploy to heroku and I have a Setting in yaml that uses erb to read from ENV. Is this the correct issue for my problem? |
@thenano i believe ERB should work fine on heroku with the latest version. try it in master? please open an issue if it doesnt work, we'll try to fix asap |
Hi, I'm still getting the following error on heroku:
I'm using the master branch. Interestingly, I don't have any config files with 7 lines. Do you have any idea what's wrong? It could be an error on my part, this is how my config in heroku is:
|
Sorry, I was away on holiday. I will look into this today... |
Hi, I've investigated this more, and it's not that it cannot get the env variable, but the format of that variable. In development environment I have the following:
It's a multiline value. I have a similar looking key in the environment variable in heroku, and what I think is happening is that since the env variable doesn't have identation, yaml fails to parse. Any thoughts on how to address this? |
I've done some manipulation in the import of my env var. Essentially, doing this works for me:
Not the pretties thing, but works :) |
@thenano I just merged this pull request. can you test in your env? @railsjedi I do not use Heroku, so maybe you can have a look as well? |
Added reading of ENV vars to the settings and a rake task to upload settings from the local files to Heroku. It works with nested settings, but not with arrays nor inline ruby expressions.
Refs #56