Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording correction for the NDBN report clearer. #4470

Closed
3 tasks
cielf opened this issue Jun 23, 2024 · 2 comments · Fixed by #4493
Closed
3 tasks

Wording correction for the NDBN report clearer. #4470

cielf opened this issue Jun 23, 2024 · 2 comments · Fixed by #4493
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Jun 23, 2024

Summary

We need to tweak the wording in the annual report to be indicate disposable -- one place left.

Why?

Avoid bank confusion

Details

This is in the annual reports. Sign in as [email protected], then click on Reports, and then 'Annual Survey'. pick a year to see the annual report for that year.

change "% difference in diaper donations" to "% difference in disposable diaper donations'

Note: We are Leaving "Money spent purchasing diapers" as is -- that matches the prompt to the users.

(Hint: see app/services/reports/summary_report_service.rb and the corresponding spec, spec/services/reports/summary_report_service_spec.rb)

Criteria for completion

  • text changed
  • screenshots of changed text
  • all tests around reports pass
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Jun 23, 2024
@clair13
Copy link
Contributor

clair13 commented Jun 23, 2024

Can I take this?

@awwaiid
Copy link
Collaborator

awwaiid commented Jun 23, 2024

@clair13 Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants