Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct word for the NDBN report #4493

Merged

Conversation

clair13
Copy link
Contributor

@clair13 clair13 commented Jul 2, 2024

Resolves #4470

Description

This pull request Fixes #4470 correcting the wording for the NDBN report , this has been tested through visual observance, running corresponding tests and checking if everything works as before.
Below you can see the screenshots what was written before and after the changes .Also a screenshot of the corresponding tests passing

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • text changed

  • screenshots of changed text

  • all tests around reports pass

Screenshots

  • Before
    Στιγμιότυπο οθόνης 2024-07-02, 19 21 16

  • After
    Στιγμιότυπο οθόνης 2024-07-02, 19 26 14

  • Corresponding test passes
    Στιγμιότυπο οθόνης 2024-07-02, 19 25 34

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cielf cielf merged commit 195d8e6 into rubyforgood:main Jul 3, 2024
19 checks passed
Copy link
Contributor

github-actions bot commented Jul 7, 2024

@clair13: Your PR Correct word for the NDBN report is part of today's Human Essentials production release: 2024.07.07.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wording correction for the NDBN report clearer.
2 participants