-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deactivated partners should not appear in the dropdown when producing a new distribution. #4515
Comments
Hi, I'd like to take a shot at this issue if no one has started working on it yet. |
Sure thing! |
I've written code to modify the query for the dropdown found in the distributions/form partial and have also manually tested it by deactivating some partners and visually checking that the new view does filter out deactivated partners while the edit view keeps them in. |
@dorner Could you field the above question? Thanks. |
I was able to figure out my question about the tests and have created a pull request. |
Summary
Limit the partners in the partner dropdown when producing a new distribution to active partners.
Why
Reduction of possible errors, just makes it easier for the banks.
Details
On new distributions only, the partners in the partner dropdown should include only active partners. They can be any other status than "Deactivated".
We still need to be able to access the deactivated partners when editing.
Criteria for completion
The text was updated successfully, but these errors were encountered: