Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4515 - Deactivated partners should not appear in the dropdown when producing a new distribution. #4638

Closed
wants to merge 15 commits into from

Conversation

ewoknock
Copy link
Contributor

@ewoknock ewoknock commented Sep 3, 2024

Resolves #4515

Description

When creating new distributions, the "Partner" dropdown should not contain deactivated partners.
However, when editing an existing distribution, you should still see deactivated partners.
This change is to reduce the number of errors and make it easier for the banks to create distributions.

To implement this feature, I added in a conditional check on the distribution form partial. If the "source" local variable has been passed to the partial and contains the value "new", then the deactivated partners will be filtered out of the partner list.
In any other case, the form partial will just render the full partner list associated with the bank.
This allows the bank to still edit distributions for partners that may have been deactivated since the distribution was created.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I first tested this manually by deactivated one of the partners.
I created a new distribution and confirmed that the partner was no longer in the dropdown.
I tried to make a new distribution but intentionally added in errors and confirmed that it would still properly filter out deactivated partners on a re-render.
I tried to edit some existing distributions and confirmed that the deactivated partners still showed up on the list.

I also created unit tests that are located in spec/system/distribution_system_spec.rb

Screenshots

New distribution after error filters out Pawnee Parent Service
image

Editing an existing distribution still allows you to select Pawnee Parent Service
image

ewoknock and others added 15 commits August 25, 2024 19:31
This commit adds in a conditional check to the _form partial that
checks where the partial is coming from. If it is being rendered from
the 'new' view, it will then generate a partner list that filters out
the deactivated partners. If it is being rendered from anywhere else,
it will generate the complete partner list unfiltered.

[Ticket: 4515]
Bumps [omniauth-google-oauth2](https://github.com/zquestz/omniauth-google-oauth2) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/zquestz/omniauth-google-oauth2/releases)
- [Changelog](https://github.com/zquestz/omniauth-google-oauth2/blob/master/CHANGELOG.md)
- [Commits](zquestz/omniauth-google-oauth2@v1.1.2...v1.1.3)

---
updated-dependencies:
- dependency-name: omniauth-google-oauth2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 6.1.3 to 6.1.4.
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](rspec/rspec-rails@v6.1.3...v6.1.4)

---
updated-dependencies:
- dependency-name: rspec-rails
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [standard](https://github.com/standardrb/standard) from 1.39.2 to 1.40.0.
- [Release notes](https://github.com/standardrb/standard/releases)
- [Changelog](https://github.com/standardrb/standard/blob/main/CHANGELOG.md)
- [Commits](standardrb/standard@v1.39.2...v1.40.0)

---
updated-dependencies:
- dependency-name: standard
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [newrelic_rpm](https://github.com/newrelic/newrelic-ruby-agent) from 9.12.0 to 9.13.0.
- [Release notes](https://github.com/newrelic/newrelic-ruby-agent/releases)
- [Changelog](https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md)
- [Commits](newrelic/newrelic-ruby-agent@9.12.0...9.13.0)

---
updated-dependencies:
- dependency-name: newrelic_rpm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [stimulus-rails](https://github.com/hotwired/stimulus-rails) from 1.3.3 to 1.3.4.
- [Release notes](https://github.com/hotwired/stimulus-rails/releases)
- [Commits](hotwired/stimulus-rails@v1.3.3...v1.3.4)

---
updated-dependencies:
- dependency-name: stimulus-rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 6.1.2 to 6.2.1.
- [Release notes](https://github.com/presidentbeef/brakeman/releases)
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md)
- [Commits](presidentbeef/brakeman@v6.1.2...v6.2.1)

---
updated-dependencies:
- dependency-name: brakeman
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Enable read-events feature in dev/staging by default

We have manually enabled this in production

* Remove more Event Sourcing separation

* Minor documentation whitespace cleanup

* Put back read_events check in specs

This is needed just a bit longer until we completely remove the feature
flag for Events
@ewoknock ewoknock closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deactivated partners should not appear in the dropdown when producing a new distribution.
4 participants