Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Purchase -- purchase total is mandatory, so it should have a star on it. #4614

Closed
2 tasks
cielf opened this issue Aug 25, 2024 · 2 comments · Fixed by #4616
Closed
2 tasks

New Purchase -- purchase total is mandatory, so it should have a star on it. #4614

cielf opened this issue Aug 25, 2024 · 2 comments · Fixed by #4616
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Aug 25, 2024

Summary

On new/edit purchase, the purchase total is a mandatory field, so the label should have a star on it.

Why?

Forestall confusion. Professionalism.

Details

To see the screens in question:
1/ New
log in as [email protected]
click "Purchases"
click "New Purchase"
The third field on the screen is labelled "Purchase Total". It should be labelled "Purchase Total *"
2/ Edit
To check the edit screen:
log in as [email protected]
click "Purchases"
click "All Purchases"
click "View" beside one of the purchases
scroll to the bottom, and click "Make a correction"

Criteria for completion

  • label changes made
  • confirmed through manual testing
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Aug 25, 2024
@isaiah3031
Copy link
Contributor

Hey! I would like to submit a PR for this issue.

@cielf
Copy link
Collaborator Author

cielf commented Aug 26, 2024

Please do!

cielf added a commit that referenced this issue Aug 29, 2024
…l-field

Adds required to Payment Total To Purchase form #4614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants