Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds required to Payment Total To Purchase form #4614 #4616

Merged

Conversation

isaiah3031
Copy link
Contributor

@isaiah3031 isaiah3031 commented Aug 26, 2024

Resolves #4614
Description: Adds asterisk to payment total fields on the purchase forms
Type of change: bug fix
Manually Tested
75E78214-D51E-44CA-9757-3284EC90775E

B500A1F5-AA01-4461-B91B-A4834E227620

@isaiah3031
Copy link
Contributor Author

@cielf Hey I'm ready for review on this. I'm also testing a Windows environment setup document. How should I go about submitting this once its done?

@cielf
Copy link
Collaborator

cielf commented Aug 27, 2024

Hey @isaiah3031 --Thanks!

Could you (please) edit the first comment (where it currently says "No description provided") to include:
Resolves #4614
Description: A description of what the change is
Type of change: In this case it's a bug fix
How has this been tested
And a screenshot of the fix.

Normally, you'd provide that information up front, and, if the pull request wasn't ready for review, you'd change the status to draft and add a [WIP] in the title. (there should have been a template?)

As per the windows setup document - if I understand, you are authoring a set up document, and want to submit it for review?
If the differences are not too extensive, I would add a section to Contributing.md with the differences for Windows. If it really needs its own document, you could add a directory under docs for alternate_setups, then put your documentation there, and add a link to it with in Contributing.md. Then just do a pull request for it, with a type of change of Documentation

@isaiah3031
Copy link
Contributor Author

Thanks for your help! I've updated the first comment. @cielf

Hey @isaiah3031 --Thanks!

Could you (please) edit the first comment (where it currently says "No description provided") to include: Resolves #4614 Description: A description of what the change is Type of change: In this case it's a bug fix How has this been tested And a screenshot of the fix.

Normally, you'd provide that information up front, and, if the pull request wasn't ready for review, you'd change the status to draft and add a [WIP] in the title. (there should have been a template?)

As per the windows setup document - if I understand, you are authoring a set up document, and want to submit it for review? If the differences are not too extensive, I would add a section to Contributing.md with the differences for Windows. If it really needs its own document, you could add a directory under docs for alternate_setups, then put your documentation there, and add a link to it with in Contributing.md. Then just do a pull request for it, with a type of change of Documentation

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cielf cielf merged commit d005d7f into rubyforgood:main Aug 29, 2024
19 checks passed
Copy link
Contributor

github-actions bot commented Sep 1, 2024

@isaiah3031: Your PR Adds required to Payment Total To Purchase form #4614 is part of today's Human Essentials production release: 2024.09.01.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Purchase -- purchase total is mandatory, so it should have a star on it.
2 participants