-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds delivery address to distribution printout/receipt #4164
Adds delivery address to distribution printout/receipt #4164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kannans5 - this looks pretty good, but it's missing one of the requirements:
Change the prompt for program address on the partner to "Program / delivery address (if different)"
@dorner where exactly this is shown (on the pdf?) or inside the app?
|
If you sign in as [email protected], click edit my organization -- there is a Program Address (if different) in that screen, which needs to be changed. Also, if you click "My organization", which is the corresponding view. These are also accessed from the bank side, though the partner agencies, then clicking on the specific partner 'edit" or "view', but I'm pretty sure they use the same partials. |
cd02ffd
to
94d8a15
Compare
Let me know if these are the changes we are looking for. |
Looks like it to me. |
Looks good to me too. Thanks! |
Hrm. When I did the pre-release test of this on staging, on a delivery distribution, I didn't get a delivery address printing out. I'm not going to hold the release on this, but something is not working properly. |
@kannans5: Your PR |
Resolves #4138
Description
Adds delivery address to distribution printout/receipt
Type of change
How Has This Been Tested?
Delivery address:
added to the left. (if delivery method is shipped or delivered)Note: I did not find any existing unit test or browser test related to distribution pdf. If someone could point me to the relevant tests, I am happy to cover this scenario.
Screenshots
If the distribution delivery method is either shipped or delivered, the print will look like this
If not no change in the receipt.