Refactor schedule action in distributions_controller for better preformance
#4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erformance - Separated the handling of JSON and HTML requests. The instance variable is not used in the HTML view, eliminating unnecessary data loading. - Implemented JSON-specific requests to leverage the `start` and `end` parameters from the FullCalendar library. This restrict tags the fetched distributions to the specified dates instead of all historical records. - Resolved the N+1 query issue by eager loading the associated partners with the distributions. - Add an index on issued_at to speed up the filtering on distributions
grantmca
force-pushed
the
4502-impove-calendar-preformance
branch
from
71f5e44
to
7905eb5
Compare
grantmca
changed the title
schedule action in distributions_controller for better preformanceschedule action in distributions_controller for better preformance
|
Ready for some review on this one, if there are any follow up questions or additional benchmarks that I need to take let me know! |
cielf
reviewed
Jul 15, 2024
|
Nice! I can work on resolving that conflict this evening, for this project do we prefer a merge or rebase strategy for getting new changes into this branch? @dorner |
|
If any review has been done, please merge and don't rebase. If it's prior to a review, rebase is better. |
dorner
approved these changes
Jul 19, 2024
|
All green - thanks! |
|
@grantmca: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4502
Description
startandendparameters from the FullCalendar library. This restrict tags the fetched distributions to the specified dates instead of all historical records.Type of change
Performance change meant to preserved the original behavior of the controller action
How Has This Been Tested?
I have tested this locally creating some mock data and testing out the loading speed of the calendar
I ran both page loads multiple times with the browser cache turned off and took the fastest time for both to ensure we are comparing as apples to apples as possible and both version can take advantage of query plan caching in PostgreSQL.
Screenshots
Before:
After:
