Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partner request units display (packs-4) #4399 #4531

Merged
merged 4 commits into from
Jul 27, 2024
Merged

Partner request units display (packs-4) #4399 #4531

merged 4 commits into from
Jul 27, 2024

Commits on Jul 14, 2024

  1. Show units in partner request view after create [#4399]

    @awwaiid
    awwaiid committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    2eeb51b View commit details
    Browse the repository at this point in the history

  2. Add spec to verify partner request view units [#4399]

    @awwaiid
    awwaiid committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    79902e3 View commit details
    Browse the repository at this point in the history

  3. Make request factory build both request-item structures 

    And also fix traits, which seem like they shouldn't have worked this
way.

[#4399]
    @awwaiid
    awwaiid committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    a62f374 View commit details
    Browse the repository at this point in the history

  4. Only build item_requests in factory when requested 

    There are unfortunately existing specs which don't pass in valid data
for building out the item_requests, so here we make it an explicit trait
that must be requested.

[#4399]
    @awwaiid
    awwaiid committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    9e59dba View commit details
    Browse the repository at this point in the history